Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option types must propagage missing fields #2726

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Option types must propagage missing fields #2726

merged 4 commits into from
Oct 30, 2023

Conversation

peczenyj
Copy link
Contributor

@peczenyj peczenyj commented Sep 21, 2023 •
edited
Loading

option DisableIndentity and ContextTimeoutEnabled sometimes are not available or not propagate betweend option types.

BTW I think it is strange that exists an option CredentialsProvider but we only use in the simple case, why Universal, Ring or Cluster does not use it?

same for Limiter

       CredentialsProvider func() (username string, password string)
	// Limiter interface used to implement circuit breaker or rate limiter.
	Limiter Limiter

@peczenyj
must propagage missing fields
ca41970 
Signed-off-by: Tiago Peczenyj <tpeczenyj@weborama.com>
@peczenyj
remove credentials provider from ring
522edfe
@peczenyj peczenyj changed the title must propagage missing fields Option types must propagage missing fields Sep 21, 2023
@ofekshenawa ofekshenawa merged commit a5fe174 into redis:master Oct 30, 2023
1 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofekshenawa ofekshenawa ofekshenawa approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peczenyj @ofekshenawa